Repository navigation
Add a close button to thread panels - #89
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A thread opened with Open in New Panel had no way to close it from the panel itself. Its custom title line (title, chips, Share, ⋯) takes the place of the dock tab, and the tab is where the × lives. Clicking the title renames the thread, so the only ways out were right-clicking the empty part of the bar or Move to Main Panel in the sidebar.
The dock now adds a × at the end of the bar whenever a custom header replaces the tab and the panel is closable. It sits after the accessory buttons, shows "Close <title>" on hover, and calls the same
closethe tab's × does. The main panel isn't closable, so it never gets one. The guide's Open in New Panel paragraph now mentions the × and Move to Main Panel.Validation on macOS:
cargo check -p threadbear-gpuipasses on current upstream main (f0b5f66). The cherry-pick conflicted with the newheader_fillsline; both are kept../check.sh --quickpassed with this change (1446 s).Not yet checked by hand in the running app.
🤖 Generated with Claude Code
Summary by cubic
Adds a close button to thread panels in the dock. Threads opened via Open in New Panel replace the dock tab with a custom header, which removed the tab's ×; the only ways to close the panel were the right-click menu or Move to Main Panel in the sidebar.
The dock now appends a × at the end of the bar whenever a custom header replaces the tab and the panel is closable. It sits after the accessory buttons, shows "Close <title>" on hover, and triggers the same close action as a tab's ×. The main panel isn't closable, so it never gets one. The guide's Open in New Panel paragraph now mentions the × and Move to Main Panel.
Written for commit 0a96cb8. Summary will update on new commits.